Skip to content

Conversation

@Sahil-Gupta584
Copy link

@Sahil-Gupta584 Sahil-Gupta584 commented Jan 2, 2026

Conneccted to tscircuit/runframe#2253

Preview:

cursorful-video-1767338417741.mp4

@Sahil-Gupta584
Copy link
Author

Should i also remove file https://github.com/tscircuit/tscircuit.com/blob/main/src/components/RunButton.tsx ?
Its nowhere getting imported since runbtn is now handled through runframe

})
}
}
}, [currentFile, files, toast])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toast dep?

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 8, 2026
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much pollution in an important file

@Sahil-Gupta584
Copy link
Author

Too much pollution in an important file

Moving of handleFormatFile() ?,
Its necessary to move so i can pass it to shortcuts array available in CodeEditor.tsx, and of course resources used by then function also needs to move.

@Excellencedev
Copy link

Too much pollution in an important file

Moving of handleFormatFile() ?, Its necessary to move so i can pass it to shortcuts array available in CodeEditor.tsx, and of course resources used by then function also needs to move.

he means move it to seperate files so there's not too much noise on an important file like that

@github-actions github-actions bot removed the stale label Jan 9, 2026
@github-actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 13, 2026

const handleFormatFile = useCallback(() => {
handleFormatFileRaw({ files, currentFile, updateFileContent, toast })
}, [currentFile, files, toast])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}, [currentFile, files, toast])
}, [currentFile, files])

}) {
if (!window.prettier || !window.prettierPlugins) return
if (!currentFile) return
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try block is too big, make it targeted

@github-actions github-actions bot removed the stale label Jan 14, 2026
@github-actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 18, 2026
Copy link
Contributor

@rushabhcodes rushabhcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seveibar
Copy link
Contributor

@Sahil-Gupta584 until perf issues are fixed, we’re not adding LoC to this

@seveibar seveibar closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants